avm2: Implement several of the AV classes - #24350
Open
ChrisCPI wants to merge 2 commits into
Open
Conversation
ChrisCPI
added
A-avm2
evilpie
reviewed
Aug 2, 2026
Implements several of the `flash.media.AV`- classes that only hold properties with no real functions. Also fixes a minor bug where `AVNetworkingParams.appendRandomQueryParameter` did not have the correct default value.
Adds the `avm2/av_classes` test, testing almost all of the currently implemented AV classes that only hold properties. The `av_networking_params` and `av_tag_data` tests have been removed, as the things that they test have been moved into this new test.
ChrisCPI
force-pushed
the
avm2-av-classes
branch
from
August 2, 2026 14:03
d245c70 to
6d3eb97
Compare
Lord-McSweeney
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements several of the
flash.media.AV- classes that only hold properties with no real functions. Also fixes a minor bug whereAVNetworkingParams.appendRandomQueryParameterdid not have the correct default value.Testing
The
avm2/av_classestest has been added, testing all of the new classes, as well as ones that were already implemented. Theav_networking_paramsandav_tag_datatests have been removed, as the things that they test have been moved into this new test.Checklist