avm2: Partially implement the rest of flash.trace.Trace - #24344
Open
ChrisCPI wants to merge 1 commit into
Open
Conversation
In the non-debugger version of Flash Player, the `setLevel` and `setListener` functions are no-ops, which makes it pretty simple to implement in this way. The actual functionality of `Trace`, which is only present in the FP debugger, is not yet implemented.
ChrisCPI
added
A-avm2
evilpie
reviewed
Aug 1, 2026
| private static var _listener:Function = null; | ||
|
|
||
| public static function getLevel(target:int = LISTENER):int { | ||
| if (target <= FILE) { |
Collaborator
There was a problem hiding this comment.
Maybe it would be more obvious to just return 0? Which is what this does anyway.
Collaborator
Author
There was a problem hiding this comment.
I did it this way to be closer to how Trace actually functions in the debugger (there are 2 different levels that can be set), but I can simplify it to that if it would be better for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the non-debugger version of Flash Player, the
setLevelandsetListenerfunctions are no-ops, which makes it pretty simple to implement in this way. The actual functionality ofTrace, which is only present in the FP debugger, is not yet implemented.Testing
Test included (the Flash Player output can't be gotten normally, see the test.toml for details)
Checklist