Skip to content

avm2: Implement more of XMLList using get_property_local - #24343

Merged
evilpie merged 2 commits into
ruffle-rs:masterfrom
evilpie:xmllist-rewrite
Aug 1, 2026
Merged

avm2: Implement more of XMLList using get_property_local#24343
evilpie merged 2 commits into
ruffle-rs:masterfrom
evilpie:xmllist-rewrite

Conversation

@evilpie

@evilpie evilpie commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Description

Implements XMLList.attribute(s) and XMLList.children using get_property_local

Testing

Should be covered by existing tests.

Checklist

  • I, a human, have self-reviewed this PR and fully understand the changes within.
  • I have made or updated tests where possible.
  • All of my commits are properly scoped, compile successfully, and pass all tests.
  • This PR does not make sense to split up into smaller PRs.
  • An LLM was involved in the authoring of this code.

@Lord-McSweeney Lord-McSweeney added A-avm2 Area: AVM2 (ActionScript 3) xml T-refactor Type: Refactor / Cleanup labels Aug 1, 2026
@evilpie
evilpie enabled auto-merge (rebase) August 1, 2026 21:01
@evilpie
evilpie merged commit 5772148 into ruffle-rs:master Aug 1, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-avm2 Area: AVM2 (ActionScript 3) T-refactor Type: Refactor / Cleanup xml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants