Skip to content

avm2: Implement XML.attribute(s) using get_property_local - #24340

Merged
evilpie merged 1 commit into
ruffle-rs:masterfrom
evilpie:xml-attribute
Aug 1, 2026
Merged

avm2: Implement XML.attribute(s) using get_property_local#24340
evilpie merged 1 commit into
ruffle-rs:masterfrom
evilpie:xml-attribute

Conversation

@evilpie

@evilpie evilpie commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Description

The specification and Flash both implement it this way.

See also #24330

Testing

Should be covered by existing tests.

Checklist

  • I, a human, have self-reviewed this PR and fully understand the changes within.
  • I have made or updated tests where possible.
  • All of my commits are properly scoped, compile successfully, and pass all tests.
  • This PR does not make sense to split up into smaller PRs.
  • An LLM was involved in the authoring of this code.

@evilpie evilpie added A-avm2 Area: AVM2 (ActionScript 3) xml T-refactor Type: Refactor / Cleanup labels Aug 1, 2026
@evilpie
evilpie marked this pull request as draft August 1, 2026 10:28
@evilpie
evilpie marked this pull request as ready for review August 1, 2026 10:53
@evilpie
evilpie merged commit 6785778 into ruffle-rs:master Aug 1, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-avm2 Area: AVM2 (ActionScript 3) T-refactor Type: Refactor / Cleanup xml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants