avm2: Store content of ContentElement subclasses as native data - #24338
Merged
Lord-McSweeney merged 5 commits intoAug 1, 2026
Conversation
Lord-McSweeney
added
A-avm2
evilpie
reviewed
Aug 1, 2026
Move `TextElement`'s text to a new enum, `ElementData`.
Fix behavior when dealing with `GraphicElement` and `GroupElement`
Lord-McSweeney
force-pushed
the
avm2-content-native
branch
from
August 1, 2026 17:37
33f95b7 to
9d1fdcf
Compare
evilpie
reviewed
Aug 1, 2026
evilpie
approved these changes
Aug 1, 2026
evilpie
left a comment
evilpie
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. I imagine we could use text directly in get_text_from_content now instead of GET_TEXT.
Lord-McSweeney
force-pushed
the
avm2-content-native
branch
from
August 1, 2026 20:44
9d1fdcf to
1b3239f
Compare
This makes it much easier to access it in the future
Lord-McSweeney
force-pushed
the
avm2-content-native
branch
from
August 1, 2026 20:50
1b3239f to
ecddcd0
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
TextElementandGroupElementto store their data in a new enum,ElementData. This will make it easier to access in the future for use in improved FTE support.Additionally, this PR fixes a couple minor issues with the
ContentElement.textgetter, andGroupElementchild validation.Unfortunately, this PR is a bit large, as everything depends on each other.
Testing
I've added a test,
avm2/groupelement_text.Checklist