avm2: Small text_block.rs apply_format cleanup - #24306
Closed
evilpie wants to merge 1 commit into
Closed
Conversation
kjarosh
reviewed
Jul 26, 2026
kjarosh
approved these changes
Jul 26, 2026
| (None, None, None, true) | ||
| }; | ||
| let fd = ef.font_description(); | ||
|
|
Member
There was a problem hiding this comment.
IMO it's easier to understand what's going on if all of the properties (font, bold, italic, is_device_font) are separate variables, but either way is much simpler than what the code currently is
Lord-McSweeney
approved these changes
Jul 26, 2026
Lord-McSweeney
added
A-avm2
5 tasks
evilpie
enabled auto-merge (rebase)
July 26, 2026 12:41
evilpie
disabled auto-merge
July 26, 2026 12:58
evilpie
enabled auto-merge (rebase)
July 26, 2026 12:59
Collaborator
Author
|
The code here changed so much, there isn't much point in keep this open. |
auto-merge was automatically disabled
August 2, 2026 12:23
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I think this makes the code easier to understand and shorter, but opinions might differ of course.
Testing
No functional change.
Checklist