Fix get_url() not appending local vars to navigate_to_url_normalized() call - #24299
Open
Slavko-P wants to merge 8 commits into
Open
Fix get_url() not appending local vars to navigate_to_url_normalized() call#24299Slavko-P wants to merge 8 commits into
Slavko-P wants to merge 8 commits into
Conversation
…ized() call While trying to get Poptropica AS2 running I noticed Ruffle fails to append local variables (in this case "island" and "room") to POST request bodies thus resulting in a blank screen when transitioning scenes. This commit fixes the issue and finally puts Poptropica AS2 into a playable state on Ruffle.
ChrisCPI
reviewed
Jul 27, 2026
kjarosh
reviewed
Jul 27, 2026
| @@ -0,0 +1,4 @@ | |||
| this.createEmptyMovieClip("test",this.getNextHighestDepth()); | |||
| test.value1 = "string"; | |||
| test.value2 = 2; | |||
Member
There was a problem hiding this comment.
What if you add properties not on test: 1. in local scope, 2. in a test's child? What if the property is virtual (a getter)? What if the property has flags (line DONT_ENUM or VERSION)?
Member
There was a problem hiding this comment.
It might be also worth adding a second call on this instead of test and checking if it works the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While trying to get Poptropica AS2 running I noticed Ruffle fails to append local variables (in this case "island" and "room") to POST request bodies thus resulting in a blank screen when transitioning scenes. This commit fixes the issue and finally puts Poptropica AS2 into a playable state on Ruffle.
Testing
Note: I only ran "npm run test" and "npm run wdio -- --firefox" for testing, with everything passing
Checklist