Skip to content

avm2: Normalize flash.globalization.Collator.compare to -1/0/1 #24148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
falpi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avm2: Normalize flash.globalization.Collator.compare to -1/0/1 #24148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/avm2/globals/flash/globalization/Collator.as
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,13 @@ package flash.globalization {

public function compare(string1:String, string2:String):int {
stub_method("flash.globalization.Collator", "compare");
return string1.localeCompare(string2);
// Flash Player normalizes the result to exactly -1, 0, or 1.
// Some callers rely on this: mx/spark collections' Sort.findItem
// does `switch (compareResult) { case -1: ...; case 1: ... }`, so a
// raw comparison delta (e.g. a character-code difference) would
// match no case and spin the binary search forever.
var result:int = string1.localeCompare(string2);
return (result < 0) ? -1 : ((result > 0) ? 1 : 0);
}

public function equals(string1:String, string2:String):Boolean {
Expand Down
Loading