Skip to content

Add warning.rbs#23

Merged
yui-knk merged 1 commit into
ruby:masterfrom
akouryy:warning-rbs
May 26, 2023
Merged

Add warning.rbs#23
yui-knk merged 1 commit into
ruby:masterfrom
akouryy:warning-rbs

Conversation

@akouryy

@akouryy akouryy commented May 18, 2023

Copy link
Copy Markdown
Contributor

Added warning.rbs based on #19.

  • The auto-generated type of @out was IO, but @out can be a String in tests.
  • I could write the type of message to be string & _ToS, but I think it would be too complex.

@akouryy akouryy marked this pull request as draft May 18, 2023 13:20
@Little-Rubyist

Copy link
Copy Markdown
Contributor

Since Warning class has been removed from typeprof-generated.rbs, there seems no need to base #19 on it.
If we are not dependent on gem_rbs_collection, then we may check out from master.

@akouryy akouryy marked this pull request as ready for review May 24, 2023 15:50
@akouryy

akouryy commented May 24, 2023

Copy link
Copy Markdown
Contributor Author

Removed the dependency on #19.

@yui-knk

yui-knk commented May 26, 2023

Copy link
Copy Markdown
Collaborator

👍

@yui-knk yui-knk merged commit c895c70 into ruby:master May 26, 2023
@akouryy akouryy deleted the warning-rbs branch May 26, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants