[32] allow access to header#137
Closed
FeminismIsAwesome wants to merge 1 commit into
Closed
Conversation
inspired from ruby-docx#73 but stripped down to just the header to see if that might be more amenable to get in. Also because of the TODO note in the update function, only supports reading these files, not updating them.
Member
|
Thanks for this contribution, @FeminismIsAwesome! 🙏 This PR had become stale and was conflicting with Your original commit and authorship are preserved there — the only change was conflict resolution. The scope is kept exactly as you intended (header reading only). I'll continue the review on #173, so I'll close this one in favor of it. Thank you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspired from #73 but stripped down to just the header to see if that might be more amenable to get in.
Also because of the TODO note in the update function, only supports reading these files, not updating them.