Migrate to ghc-lib-parser to build on GHC 9.10#41
Open
kqr wants to merge 1 commit into
Open
Conversation
Author
|
I suppose the main difference between this and #40 is that in this PR I deliberately tried to keep changes minimal. I think other improvements (cleanup, nixifying, etc.) can be done separately. |
The main potential objection to this change is that it cannot use GHC for parsing CPP, but uses cpphs instead. The cpphs library is apparently somewhat more lenient and will skip past minor syntax errors such as skipping missing includes and unterminated ifs. This means complexity will be calculated slightly differently in files where that is the case. A test definition has been changed to mirror this difference. The upgrade to GHC 9 also forces smaller rewrites to get rid of old dependencies (dirstream, lens-simple) that likewise don't build on modern GHC versions – these are small and self-contained in Walker.hs and Results.hs. The build system has switched from Stack to Cabal, mostly because that's what I have and know. I wouldn't know how to upgrade the Stack bits so I dropped them instead. Unfortunately, the CI tooling implied by .travis.yml also depends on Stack, so someone may want to reinstate it.
kqr
force-pushed
the
migrate-to-ghc-lib-parser-to-build-on-ghc-9
branch
from
598ff05 to
e1925d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main potential objection to this change is that it cannot use GHC for parsing CPP, but uses cpphs instead. The cpphs library is apparently somewhat more lenient and will skip past minor syntax errors such as skipping missing includes and unterminated ifs. This means complexity will be calculated slightly differently in files where that is the case. A test definition has been changed to mirror this difference.
The upgrade to GHC 9 also forces smaller rewrites to get rid of old dependencies (dirstream, lens-simple) that likewise don't build on modern GHC versions – these are small and self-contained in Walker.hs and Results.hs.
The build system has switched from Stack to Cabal, mostly because that's what I have and know. I wouldn't know how to upgrade the Stack bits so I dropped them instead. Unfortunately, the CI tooling implied by .travis.yml also depends on Stack, so someone may want to reinstate it.