Skip to content

feat: add startupProbe to Helm Chart #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dekarl wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add startupProbe to Helm Chart #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm/opensoho/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: opensoho
description: A Helm chart for OpenSoho - OpenWrt management platform
type: application
version: 0.2.0
appVersion: "v0.7.3"
version: 0.2.1
appVersion: "v0.13.0"
keywords:
- opensoho
- openwrt
Expand Down
1 change: 1 addition & 0 deletions helm/opensoho/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ The command removes all the Kubernetes components associated with the chart and
| --------------------------- | -------------------------------------------------------------------------------------------------------------------------------- | ------- |
| `healthCheck.enabled` | Enable readiness probe | `true` |
| `livenessProbe.enabled` | Enable liveness probe | `true` |
| `startupProbe.enabled` | Enable startup probe | `true` |

## Configuration and installation details

Expand Down
12 changes: 10 additions & 2 deletions helm/opensoho/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ spec:
httpGet:
path: /api/health
port: http
initialDelaySeconds: {{ .Values.healthCheck.initialDelaySeconds }}
periodSeconds: {{ .Values.healthCheck.periodSeconds }}
timeoutSeconds: {{ .Values.healthCheck.timeoutSeconds }}
failureThreshold: {{ .Values.healthCheck.failureThreshold }}
Expand All @@ -61,12 +60,21 @@ spec:
httpGet:
path: /api/health
port: http
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.livenessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.livenessProbe.failureThreshold }}
successThreshold: {{ .Values.livenessProbe.successThreshold }}
{{- end }}
{{- if .Values.startupProbe.enabled }}
startupProbe:
httpGet:
path: /api/health
port: http
periodSeconds: {{ .Values.startupProbe.periodSeconds }}
timeoutSeconds: {{ .Values.startupProbe.timeoutSeconds }}
failureThreshold: {{ .Values.startupProbe.failureThreshold }}
successThreshold: {{ .Values.startupProbe.successThreshold }}
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumeMounts:
Expand Down
19 changes: 15 additions & 4 deletions helm/opensoho/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ ingress:
# hosts:
# - opensoho.local

httproute:
enabled: false
hostname: opensoho.local
parentRef:

Comment on lines +60 to +64

@dekarl dekarl Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, that was not ment to be part of it

resources:
limits:
cpu: 500m
Expand Down Expand Up @@ -92,21 +97,27 @@ persistence:
# Mount path for persistent data
mountPath: /ko-app/pb_data

# Health checks
# readinessProbe, should traffic go to this replica?
healthCheck:
enabled: true
initialDelaySeconds: 30
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 3
successThreshold: 1

# Liveness probe
# Liveness probe, should we kill this replica?
livenessProbe:
enabled: true
initialDelaySeconds: 30
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 3
successThreshold: 1

# Startup probe, is this replica ready for service?
startupProbe:
enabled: true
periodSeconds: 10
timeoutSeconds: 5
# 30 * 10 => 5 minutes to start up, before giving up
failureThreshold: 30
successThreshold: 1
Loading