Don't overwrite the loaded filename when opening includes#101
Open
mbuijs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filename of the worldfile is used to find include files, bitmaps (and maybe other things?). When handling includes that are found through the
STAGEPATH, the filename of the worldfile is overwritten. Later on when for example loading bitmaps, theSTAGEPATHis not evaluated anymore, instead only the filename is used. In my case bitmaps are located next to the original world file, not near files somewhere in theSTAGEPATH.Another scenario is the save functionality, which will actually attempt to save the world file to the path of the last include instead of the original world file.