aruco_detectionサンプルの追加#188
Open
KuraZuzu wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Sciurus17向けに ArUco マーカー検出のサンプル(C++/Python)を追加し、検出したマーカーの姿勢を TF として配信できるようにするPRです(crane_x7_ros のサンプル移植ベース)。
Changes:
- C++版
aruco_detectionノードを追加し、/head_camera/color/image_raw+ CameraInfo からマーカー姿勢を推定して TF 配信 - Python版
aruco_detectionノードを追加し、同様に TF 配信 - 既存の
camera_example.launch.py/ ビルド・実行メタデータ(CMake / setup.py)の選択肢にaruco_detectionを追加
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sciurus17_examples/src/aruco_detection.cpp | ArUco検出+Pose推定+TF配信のC++サンプルを新規追加 |
| sciurus17_examples/launch/camera_example.launch.py | 実行例の説明文に aruco_detection を追記 |
| sciurus17_examples/CMakeLists.txt | C++サンプル実行ファイル一覧に aruco_detection を追加 |
| sciurus17_examples_py/setup.py | Pythonサンプルの entry point に aruco_detection を追加 |
| sciurus17_examples_py/sciurus17_examples_py/aruco_detection.py | ArUco検出+Pose推定+TF配信のPythonサンプルを新規追加 |
| sciurus17_examples_py/launch/camera_example.launch.py | 実行例の説明文に aruco_detection を追記 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
aruco_detectionサンプルを追加します。
crane_x7_ros の
aruco_detectionサンプルをベースに実装しています。基本的には
crane_x7_rosからの移植ですが、sciurus17_ros向けに以下の変更・修正を加えています。sciurus17_examples/src/aruco_detection.cppsciurus17_examples_py/sciurus17_examples_py/aruco_detection.pyaruco_detectionサンプルとして追加しました。Does this close any currently open issues?
しません。
How has this been tested?
実機とGazeboで動作を確認しました。
Any other comments?
Gazebo上でのArUcoマーカーの認識動作は少し不安定です。キューブを初期位置から少し動かしたり照明条件を変えると認識される場合があることからも、Gazeboのレンダリング上の光の当たり方が影響している可能性が高そうです。
Checklists