Skip to content

不要なxacro:propertyの定義を廃止#24

Merged
Kuwamai merged 4 commits into
ros2from
refactoring/property
Jul 6, 2026
Merged

不要なxacro:propertyの定義を廃止#24
Kuwamai merged 4 commits into
ros2from
refactoring/property

Conversation

@YusukeKato

@YusukeKato YusukeKato commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

What does this implement/fix?

xacroファイルのpropertyの定義のうち、不要なものを廃止します。

Does this close any currently open issues?

しません。

How has this been tested?

mock_components、Gazebo、実機でテストします。

Any other comments?

ありません。

Checklists

@YusukeKato

Copy link
Copy Markdown
Contributor Author

mock_compoentsとGazebo環境で動作確認済みです。

@YusukeKato YusukeKato requested a review from Copilot July 3, 2026 08:15
@YusukeKato YusukeKato self-assigned this Jul 3, 2026
@YusukeKato YusukeKato marked this pull request as ready for review July 3, 2026 08:20

@Kuwamai Kuwamai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点リクエストしました

Comment thread urdf/sciurus17.urdf.xacro Outdated
@YusukeKato

Copy link
Copy Markdown
Contributor Author

実機でも動作確認できました。

@YusukeKato YusukeKato requested a review from Kuwamai July 6, 2026 08:02

@Kuwamai Kuwamai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです

@Kuwamai Kuwamai merged commit 1ebd56a into ros2 Jul 6, 2026
2 checks passed
@Kuwamai Kuwamai deleted the refactoring/property branch July 6, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants