Handle NaN to enforce weak ordering in sort in transverse_deviation - #2169
Open
MichaelChirico wants to merge 1 commit into
Open
Handle NaN to enforce weak ordering in sort in transverse_deviation#2169MichaelChirico wants to merge 1 commit into
MichaelChirico wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2168. Suggested by Gemini, it looks right to me (especially it matches the lambda in sort.cpp), and the examples work+tests pass with it applied.
Given that existing examples already failed, I elected not to add any new tests, but we could add some in principle.