Skip to content

elevation sorting and flow accumelation criteria for flow path to calculate Flowdir - #2149

Merged
rhijmans merged 10 commits into
rspatial:masterfrom
ecor:master
Jul 30, 2026
Merged

rhijmans merged 10 commits into
rspatial:masterfrom
ecor:master

Conversation

@ecor

@ecor ecor commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

I fixed some issues in flowDir function, introducing flow accumulation critaria for correction factor in converging flow apth and eleveation sorting when flow paths were tracked. This is current update. When I understand and look into rspatial code, I will submit further long documentation about flowDir function. Thank you best @ecor

@rhijmans
rhijmans merged commit 46ee334 into rspatial:master Jul 30, 2026
6 checks passed
@rhijmans

Copy link
Copy Markdown
Member

Very good, thanks.

@kadyb

kadyb commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

From clang:

catchments.cpp:1166:7: warning: unused variable 'flowacci' [-Wunused-variable]
 1166 |   int flowacci=*(flowaccm+i);
      |       ^~~~~~~~
1 warning generated.

rhijmans added a commit that referenced this pull request Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants