Skip to content

fix: guard against TopDocs::with_limit(0) panic #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: guard against TopDocs::with_limit(0) panic #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05be4a2
fix: guard against TopDocs::with_limit(0) panic in all call sites
Copilot Apr 4, 2026
8b08991
fix: return empty matched_gavs when total is 0 in list_packages_for_gavs
Copilot Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/index/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,11 @@ impl IndexReader {
} else {
sq.offset.saturating_add(sq.limit)
};
let (top_docs, _) =
searcher.search(&combined, &(TopDocs::with_limit(fetch_count), Count))?;
let (top_docs, _) = if fetch_count == 0 {
(vec![], 0)
} else {
searcher.search(&combined, &(TopDocs::with_limit(fetch_count), Count))?
};

let mut all_results: Vec<SearchResult> = top_docs
.into_iter()
Expand Down Expand Up @@ -181,10 +184,14 @@ impl IndexReader {
(sliced, pre_filter_count)
} else {
// Search mode: let Tantivy handle offset/limit with relevance ranking
let (top_docs, total_count) = searcher.search(
&combined,
&(TopDocs::with_limit(sq.limit).and_offset(sq.offset), Count),
)?;
let (top_docs, total_count) = if sq.limit == 0 {
(vec![], searcher.search(&combined, &Count)?)
} else {
searcher.search(
&combined,
&(TopDocs::with_limit(sq.limit).and_offset(sq.offset), Count),
)?
};
let results: Vec<SearchResult> = top_docs
.into_iter()
.map(|(_score, addr)| {
Expand Down Expand Up @@ -332,6 +339,9 @@ impl IndexReader {
};

let total = searcher.search(&query, &Count)?;
if total == 0 {
return Ok((vec![], matched_gavs));
}
let top_docs = searcher.search(&query, &TopDocs::with_limit(total))?;

let mut pkg_counts: BTreeMap<String, usize> = BTreeMap::new();
Expand Down Expand Up @@ -374,6 +384,9 @@ impl IndexReader {

let query = BooleanQuery::new(clauses);
let total = searcher.search(&query, &Count)?;
if total == 0 {
return Ok((vec![], vec![]));
}
let top_docs = searcher.search(&query, &TopDocs::with_limit(total))?;

let mut pkg_counts: BTreeMap<String, usize> = BTreeMap::new();
Expand Down