This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Make IpldDag and Ipns async_traits#285
Open
ljedrz wants to merge 2 commits into
Open
Conversation
Signed-off-by: ljedrz <ljedrz@gmail.com>
Member
Author
|
Oof, forgot the tests 😄. |
ljedrz
marked this pull request as draft
August 5, 2020 10:45
Signed-off-by: ljedrz <ljedrz@gmail.com>
ljedrz
force-pushed
the
async_trait_dag_ipns
branch
from
August 5, 2020 10:50
ed13282 to
aca0b14
Compare
ljedrz
marked this pull request as ready for review
August 5, 2020 11:00
koivunej
reviewed
Aug 11, 2020
koivunej
left a comment
koivunej
left a comment
Collaborator
There was a problem hiding this comment.
Not entirely sure if we need to go into this direction, at least yet (as discussed). Apart from async_trait, we could see if pollable-async-trait could be used but lets consider this later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a part of #264 which was surprisingly painless and seems more idiomatic than the current approach of creating ad-hoc intermediate
structs containing anIpfs(which is internally anArc).