Skip to content

fix(zmx): preserve scrollback tail on reattach - #299

Merged
rrvsh merged 1 commit into
primefrom
fix/zmx-scrollback-reattach
Oct 15, 2026
Merged

rrvsh merged 1 commit into
primefrom
fix/zmx-scrollback-reattach

Conversation

@rrvsh

@rrvsh rrvsh commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • backport Matthias Bertschy’s standalone ZMX terminal-restoration fix from neurosnap/zmx#271
  • patch the Nixpkgs ZMX 0.8.1 package without including zmosh
  • preserve the final viewport-height rows when ZMX reconstructs scrollback after reattaching

Upstream commit: bd4d4c9

Validation

  • nix develop -c just format-nix
  • nix develop -c just check-nix
  • built the patched ZMX derivation on x86_64-linux; the package’s Zig checks, including the backported regression test, passed
  • git diff --check

No host was rebuilt and no existing ZMX session was touched.

''} ${config.home.homeDirectory}/.pi/agent/sessions/.stignore
'';
packages = [
pkgs.zmx

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we inline the above variable declaration and comment into here, please - we should avoid single use helpers

Backport Matthias Bertschy’s standalone terminal-restoration fix from neurosnap/zmx#271. This keeps the final viewport-height rows when ZMX reconstructs scrollback after reattaching.

Co-authored-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@rrvsh
rrvsh force-pushed the fix/zmx-scrollback-reattach branch from 66cc67a to dd4ecde Compare October 15, 2026 05:22
@rrvsh
rrvsh marked this pull request as ready for review October 15, 2026 05:32
@rrvsh
rrvsh merged commit 251b218 into prime Oct 15, 2026
4 checks passed
@rrvsh
rrvsh deleted the fix/zmx-scrollback-reattach branch October 15, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant