chore(phpcs): annotate 223 PreparedSQL + NonceVerification false positives - #26
Merged
Merged
Conversation
…tives All flagged SQL uses $wpdb->prepare() correctly; all flagged form handlers verify nonces in parent/calling methods. Added phpcs:disable at repository file level and phpcs:ignore on individual lines with documented reasons. No code changes — annotations only. https://claude.ai/code/session_013mTv5ethMq15faTc8FKta9
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
223 PHPCS violations for
WordPress.DB.PreparedSQLandWordPress.Security.NonceVerificationwere all confirmed as false positives — the code already uses$wpdb->prepare()and verifies nonces correctly, but PHPCS can't trace across method boundaries or class properties.What changed
No code changes — annotations only.
phpcs:disable WordPress.DB.PreparedSQL.NotPrepared(SQL is always passed through$wpdb->prepare())phpcs:ignorewith documented reason on isolatedInterpolatedNotPrepared/NotPreparedlinesphpcs:ignore WordPress.Security.NonceVerification.Missingwith reference to the method where nonce is verifiedBefore/after
Verification
Test plan