feat(phpstan): promote to level 7 - #24
Merged
Merged
Conversation
- Fixed 164 null-safety issues (argument.type, return.type, offsetAccess.*)
across 51 files, including:
- 122 argument.type (strtotime ?: time(), wp_json_encode ?: '', esc_attr
coercions, fopen guards, get_permalink ?: '', etc.)
- 29 return.type (ob_get_clean ?: '', int casts on $wpdb->query, etc.)
- 11 offsetAccess.notFound (?? '' for optional array keys)
- 1 offsetAccess.invalidOffset (float|int key cast)
- 1 assign.propertyType (tightened constructor type)
- Added 20 @phpstan-ignore-next-line for $wpdb->prepare() literal-string
false positives (dynamically-built SQL from trusted internal logic)
- Added baseline for 518 remaining WP-idiom errors (property.notFound
on stdClass from $wpdb queries, etc.) — these require per-callsite
docblock annotations, out of scope for this sprint.
- All 3165 existing tests pass.
https://claude.ai/code/session_013mTv5ethMq15faTc8FKta9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Level 6 was clean (empty baseline), so this promotes to level 7 for stronger null-safety analysis on all new code.
What changed
argument.type—string|false→?: '',(string)casts,is_string()guardsreturn.type—ob_get_clean() ?: '',wp_json_encode() ?: ''offsetAccess.notFound—$arr['key'] ?? ''for optional array keysoffsetAccess.invalidOffset+ 1assign.propertyType@phpstan-ignore-next-linefor$wpdb->prepare()literal-string false positives (dynamically built SQL from trusted internal logic — standard WP pattern)class-ffc-form-cache.php:328referenced'FFC_Form_Cache'(non-existent class) instead of the namespacedFormCacheproperty.notFound,method.notFoundon stdClass from$wpdb->get_row()/get_results()) — these require per-callsite docblock annotations, out of scope for this sprintphpstan.neon.distVerification
Test plan