refactoring: Address, AssignVehicle, DriversScheduleswithTerritoriesV… - #22
Open
r4m-juan wants to merge 2 commits into
Open
refactoring: Address, AssignVehicle, DriversScheduleswithTerritoriesV…#22r4m-juan wants to merge 2 commits into
r4m-juan wants to merge 2 commits into
Conversation
…3, GetOrdersByCustomFields, OrdersManager, PickupDropoffJoint, RoutingManager, TelematicsGetVendorInfo, TelematicsManager
r4m-juan
commented
Dec 20, 2023
r4m-juan
left a comment
r4m-juan
left a comment
Collaborator
Author
There was a problem hiding this comment.
@r4m-cristianv Please check my comments
|
|
||
| try { | ||
| DataObject responseObject = manager.runOptimization(optParameters); | ||
| DataObject responseObject = manager.runOptimizationWithRedirect0(optParameters); |
Collaborator
Author
There was a problem hiding this comment.
This is not needed we have this method:
public RoutingManager(String apiKey, boolean disableRedirects) {
super(apiKey, disableRedirects);
}
to disabled redirects
When that method is used we do this:
if (this.disableRedirects) {
builder.addParameter("redirect", "0");
client = HttpClients.custom().disableRedirectHandling().build();
}
There was a problem hiding this comment.
Yes, you are right, I missed this
| try { | ||
| TelematicsVendorsInfo vendor = manager.getTelematicsVendorInfo("3"); | ||
| System.out.println(vendor.getVendor()); | ||
| TelematicsVendorInfo vendor = manager.getTelematicsVendorInfo("3", "62f6197505da3f545c4fc9cb87ae76c9"); |
Collaborator
Author
There was a problem hiding this comment.
@r4m-cristianv Why you added this uuid key here
There was a problem hiding this comment.
I was getting unauthorized access error, that is why I added this api token, but now I double checked and the test passed without api token, so I removed it
| return this.makeJSONRequest(RequestMethod.POST, builder, parameters, DataObject.class); | ||
| } | ||
|
|
||
| public DataObject runOptimizationWithRedirect0(OptimizationParameters parameters) throws APIException { |
r4m-glib-pakharenko
force-pushed
the
refactoring_sdk
branch
from
August 13, 2026 14:05
1e3c8ab to
4449596
Compare
r4m-glib-pakharenko
force-pushed
the
master
branch
from
August 13, 2026 14:05
13fbc54 to
40e7149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…3, GetOrdersByCustomFields, OrdersManager, PickupDropoffJoint, RoutingManager, TelematicsGetVendorInfo, TelematicsManager