Add tests for custom hooks (useShows, useSongs, useDeleteShow)#100
Closed
rossvz wants to merge 1 commit into
Closed
Add tests for custom hooks (useShows, useSongs, useDeleteShow)#100rossvz wants to merge 1 commit into
rossvz wants to merge 1 commit into
Conversation
Added comprehensive test coverage for three custom hooks that manage data fetching and manipulation. All hooks now have 100% coverage with tests that verify loading states, data transformation, memoization, and edge cases. Test additions: - useDeleteShow.test.ts: 4 tests covering Firebase remove operations and callback memoization behavior - useShows.test.ts: 7 tests for show data fetching, formatting, and filtering of past shows - useSongs.test.ts: 8 tests for song data with complex sorting (visible > votes > title) and case-insensitive search filtering Updated Firebase mocks in test setup to include limitToLast and startAfter for query operations used by these hooks. Test suite now at 52 passing tests in 8 files with overall coverage increased from 46.39% to 48.6%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetching and manipulation. All hooks now have 100% coverage with tests that
verify loading states, data transformation, memoization, and edge cases.
Test additions:
callback memoization behavior
filtering of past shows
votes > title) and case-insensitive search filtering
Updated Firebase mocks in test setup to include limitToLast and startAfter
for query operations used by these hooks.
Test suite now at 52 passing tests in 8 files with overall coverage
increased from 46.39% to 48.6%.