Repository navigation
Feat: Carry Codex's Responses WebSocket and parse every turn on it #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0fc2e73
feat: Carry Codex's Responses WebSocket and parse every turn on it
Alan-Cha 6d4a59b
fix: Pin a WebSocket turn's pipeline and parse requests up to 32 MiB
Alan-Cha 35d7181
test: Pin Codex's WebSocket interrupt, and record the live TUI and mu…
Alan-Cha 05b21b4
fix: Record a turn the client abandons as client_canceled, not upstre…
Alan-Cha d8297e4
fix: Read close frames and error codes when recording a WebSocket turn
Alan-Cha e72133a
docs: Record the API-key and Linux WebSocket runs in the Codex doc
Alan-Cha 7f018d7
Merge main into feat/codex-websocket
Alan-Cha a221f0f
test: Give the large-WebSocket-turn test room on a slow runner
Alan-Cha a2d37f5
fix: Fix the WebSocket relay's review findings and CodeQL alerts
Alan-Cha 944bd00
fix: Build each WebSocket turn's session view as HTTPS does
Alan-Cha 4319011
refactor: Drop the CodeQL-only log wrapper and size check
Alan-Cha cb3f4fb
fix: Don't finish a queued prewarm again when the socket closes
Alan-Cha 2bc2b0d
Merge main into feat/codex-websocket
Alan-Cha 0b7725b
Merge main into feat/codex-websocket
Alan-Cha 7208fef
Merge main into feat/codex-websocket
Alan-Cha 167e1b6
fix: Carry the handshake's attribution onto each WebSocket turn
Alan-Cha 38ee4f4
Merge main into feat/codex-websocket
Alan-Cha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "forward restores the stripped GET" is the pre-#1549 behaviour. Since the merge,
forwardhands the upgrade across and splices the 101, the way every other WebSocket is handled (see theResponsesWebSocketsForwardcomment inconfig.go). Suggest:and forward splices it like any other WebSocket, its frames opaque.