Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NaviSonicPlayPlaylisthandler searches Navidrome using the rawslot.value, which is what Alexa heard rather than the resolved slot typevalue. For non-English playlist names the two frequently differ:
chartsHörerchartswerner chartsHörerchartsThe slot type resolved correctly with
ER_SUCCESS_MATCHin both cases, butthe search ran with the raw value and failed. Synonyms defined in the slot
type have no effect, since the resolution is never read.
This adds a small helper that prefers the resolution and falls back to the
raw value when no authority matched, so open slot types (
AMAZON.Artist,AMAZON.MusicAlbum, ...) keep their current behaviour.Tested against Navidrome 0.61.2 with a de-DE skill and playlist names
containing umlauts.