Skip to content

refactor: port Firo watcher from RPC to ElectrumX#14

Merged
vorujack merged 4 commits into
rosen-bridge:snapshot-firo-releasefrom
navidR:feature/navidr/switch-to-electrumx
Jun 27, 2026
Merged

refactor: port Firo watcher from RPC to ElectrumX#14
vorujack merged 4 commits into
rosen-bridge:snapshot-firo-releasefrom
navidR:feature/navidr/switch-to-electrumx

Conversation

@navidR

@navidR navidR commented May 31, 2026

Copy link
Copy Markdown

This PR ports the watcher’s Firo path from firod RPC to ElectrumX by replacing the Firo RPC connector/scanner wiring with FiroElectrumXNetwork, FiroElectrumXScanner, FiroObservationExtractor, and the Firo ElectrumX scanner health check, while updating config/env names from firo.rpc to firo.electrumx.

Note: Watcher depends on new ElectrumX exports from the scanner and health-check packages, so this PR can only pass install/tests after those PRs are merged, released, and the watcher lockfile is updated to consume the new package versions.

@RaaCT0R RaaCT0R left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Required Change

Seems you've committed your changes after the dev branch. You need to do them after the snapshot-firo-release branch. You should create the PR targeted to snapshot-firo-release too. Because there are some changes in the dev that should not be included in the next release which is focused only on Firo integration (Note that it's only for watcher repo. The guard-service repo is okay and should follow the dev branch).

@navidR
navidR force-pushed the feature/navidr/switch-to-electrumx branch from 9a390f1 to d93c021 Compare June 19, 2026 15:55
@navidR
navidR changed the base branch from dev to snapshot-firo-release June 19, 2026 16:03
@navidR

navidR commented Jun 19, 2026

Copy link
Copy Markdown
Author

🚫 Required Change

Seems you've committed your changes after the dev branch. You need to do them after the snapshot-firo-release branch. You should create the PR targeted to snapshot-firo-release too. Because there are some changes in the dev that should not be included in the next release which is focused only on Firo integration (Note that it's only for watcher repo. The guard-service repo is okay and should follow the dev branch).

Thanks. Addressed.

Comment thread config/default.yaml
Comment thread src/utils/networkConnectorManagers.ts Outdated
Comment thread docker/custom-environment-variables.yaml Outdated
@vorujack
vorujack merged commit b8ee5ab into rosen-bridge:snapshot-firo-release Jun 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants