Fetch all withdrawal assets for token select#27
Open
alan-provable wants to merge 1 commit into
Open
Conversation
|
@alan-provable is attempting to deploy a commit to the rosen-bridge Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Author
|
Quick check note: the failing Vercel statuses I can see are asking a rosen-bridge team member to authorize preview deployments for this fork. The local validation I could run passed ( |
zargarzadehm
requested review from
abdolian and
zargarzadehm
and removed request for
zargarzadehm
June 30, 2026 08:39
alan-provable
force-pushed
the
fix/watcher-withdraw-assets-pagination
branch
from
June 30, 2026 11:36
6968c72 to
11f5334
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10.
What changed
/address/assetswithoffsetandlimituntil it has collected the API-reportedtotal.Why
The withdrawal token select only used the default
/address/assetsresponse. When an address had more tokens than the default page size, later tokens never appeared in the select.Validation
git diff --checkI also tried
npm ci --ignore-scripts --no-audit --no-fund, but this checkout cannot install cleanly as-is in my environment because the package lock is out of sync and my local Node/npm versions are below the repo engine requirement.