Skip to content

Fetch all withdrawal assets for token select#27

Open
alan-provable wants to merge 1 commit into
rosen-bridge:devfrom
alan-provable:fix/watcher-withdraw-assets-pagination
Open

Fetch all withdrawal assets for token select#27
alan-provable wants to merge 1 commit into
rosen-bridge:devfrom
alan-provable:fix/watcher-withdraw-assets-pagination

Conversation

@alan-provable

Copy link
Copy Markdown

Closes #10.

What changed

  • Added a paginated loader for the Watcher withdrawal token list.
  • The loader keeps calling /address/assets with offset and limit until it has collected the API-reported total.
  • Kept the withdrawal form on SWR, so loading and caching behavior still follows the existing app pattern.

Why

The withdrawal token select only used the default /address/assets response. When an address had more tokens than the default page size, later tokens never appeared in the select.

Validation

  • git diff --check

I also tried npm ci --ignore-scripts --no-audit --no-fund, but this checkout cannot install cleanly as-is in my environment because the package lock is out of sync and my local Node/npm versions are below the repo engine requirement.

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

@alan-provable is attempting to deploy a commit to the rosen-bridge Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
vercel Bot temporarily deployed to Preview – ui-guard June 29, 2026 14:35 Inactive
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ui-guard Skipped Skipped Jun 30, 2026 11:36am

Request Review

@alan-provable

alan-provable commented Jun 29, 2026

Copy link
Copy Markdown
Author

Quick check note: the failing Vercel statuses I can see are asking a rosen-bridge team member to authorize preview deployments for this fork. The local validation I could run passed (git diff --check). npm ci --ignore-scripts --no-audit --no-fund is blocked before install because the current lockfile is out of sync with apps/guard/package.json and this machine's Node/npm are below the repo engine requirement. Happy to rerun any maintainer-preferred checks once the preview authorization or lockfile baseline is cleared.

@zargarzadehm
zargarzadehm requested review from abdolian and zargarzadehm and removed request for zargarzadehm June 30, 2026 08:39
@alan-provable
alan-provable force-pushed the fix/watcher-withdraw-assets-pagination branch from 6968c72 to 11f5334 Compare June 30, 2026 11:36
@vercel
vercel Bot temporarily deployed to Preview – ui-guard June 30, 2026 11:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pagination to Watcher withdrawal token select

1 participant