Skip to content

fix: remove ignoreBuildErrors and resolve typed-route errors (#8)#22

Open
odiseusme wants to merge 1 commit into
rosen-bridge:devfrom
odiseusme:fix/issue-8-remove-ignorebuilderrors
Open

fix: remove ignoreBuildErrors and resolve typed-route errors (#8)#22
odiseusme wants to merge 1 commit into
rosen-bridge:devfrom
odiseusme:fix/issue-8-remove-ignorebuilderrors

Conversation

@odiseusme

Copy link
Copy Markdown

Fixes #8.

  • Removes typescript: { ignoreBuildErrors: true } from apps/guard/next.config.js and apps/watcher/next.config.js.
  • Resolves the two TypeScript errors that surfaced in apps/watcher/src/app/App.tsx:
    • Anchor wrapper now casts props.href to Route for compatibility with typedRoutes: true
    • push router method now casts href to Route for the same reason
  • npm run type-check passes cleanly in both apps/guard and apps/watcher with the flag removed.
  • lint-staged hooks (prettier, eslint, type-check, knip) all pass.
  • No package.json or package-lock.json changes.

@vercel

vercel Bot commented May 7, 2026

Copy link
Copy Markdown

@odiseusme is attempting to deploy a commit to the rosen-bridge Team on Vercel.

A member of the Team first needs to authorize it.

@abdolian

Copy link
Copy Markdown
Collaborator

Your branch is out of date. Please update it with the latest changes first so we can review and merge your merge request.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file no longer needs changes—we’ve already updated it in another merge request.

@abdolian abdolian Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your branch is not up to date with the latest version of the dev branch. Please update your branch and revert the changes in this file.

Your commit still includes three incorrect files and should only affect apps/guard/next.config.js and apps/watcher/next.config.js.

@odiseusme
odiseusme force-pushed the fix/issue-8-remove-ignorebuilderrors branch from bd77c2f to 43ee8eb Compare June 30, 2026 20:17
@odiseusme

Copy link
Copy Markdown
Author

Thanks @abdolian - rebased onto the latest dev. The App.tsx change is dropped since dev already has the fix from the other MR, so this PR now only carries the ignoreBuildErrors removal and the typed-route fixes in the two next.config.js files. Branch is up to date and conflict-free; ready for review whenever you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ignoreBuildErrors from Next config

2 participants