ros2param: fix parameter delete typo (use instance instead of class)#1243
Open
longway-code wants to merge 2 commits into
Open
ros2param: fix parameter delete typo (use instance instead of class)#1243longway-code wants to merge 2 commits into
longway-code wants to merge 2 commits into
Conversation
longway-code
changed the title
…ment The delete parameter command was assigning to the class attribute Parameter.name instead of the instance attribute parameter.name, causing delete requests to be sent without the target parameter name. Also added test_verb_delete.py to test the delete command. Signed-off-by: Longwei Liu <longwei.llw@gmail.com>
longway-code
force-pushed
the
fix-ros2param-delete
branch
from
bf8194c to
4552930
Compare
fujitatomoya
approved these changes
Jun 14, 2026
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
lgtm.
this is real bug which has been several years, thanks for fixing this.
Collaborator
|
Pulls: #1243
|
Collaborator
Signed-off-by: Longwei Liu <longwei.llw@gmail.com>
Author
Thanks for the review! I have wrapped the long comment lines, The flake8 linting errors should be resolved now. |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros2 param deletewas assigning to the class attributeParameter.nameinstead of the instanceparameter.name.While this happens to work for one-off CLI calls, it pollutes the
Parameterclass definition by replacing the property descriptor with a string. This causes any subsequent attempts to instantiateParametermessages in the same process to crash withAttributeError.This PR fixes the typo and adds a basic integration test (
test_verb_delete.py).