fix: Improved thread usage under congestion - #3258
Open
jmachowinski wants to merge 1 commit into
Open
Conversation
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
fujitatomoya
approved these changes
Sep 6, 2026
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
lgtm with minor comment.
Comment on lines
+295
to
299
| /** | ||
| * Will be called while holding the ready_callback_groups_mutex lock | ||
| */ | ||
| virtual ExecutableEntityWithInfo get_next_ready_entity_intern() = 0; | ||
| virtual ExecutableEntityWithInfo get_next_ready_entity_intern( |
Collaborator
There was a problem hiding this comment.
now i do not explain why those virtual methods overload in FirstInFirstOutScheduler are public? before the PR, they were self-locking but now it is caller's responsibility as mentioned. how about moving both pure-virtual declarations into the protected: section (nothing outside the class hierarchy should call them)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some improvements on thread wakeups
Fixes # (issue)
Is this user-facing behavior change?
no
Did you use Generative AI?
no
Additional Information