[master]{rolling} rosx-introspection: remove cmake.cpm - #1805
Open
vermaete wants to merge 1 commit into
Open
Conversation
No fetching during compilation Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
vermaete
marked this pull request as ready for review
August 25, 2026 07:27
robwoolley
changed the title
Collaborator
|
Thanks @vermaete I see that rosx-introspection builds right now. I suspect that the CPM will fail in an airgapped environment. Would it perhaps be better for the bitbake fetch to download the file mentioned in cmake/CPM.cmake and then apply a patch to include that pre-fetched version instead? |
Contributor
Author
|
@robwoolley I think that thanks to the DEPENDS in the generated recipe there will be no need fetch the files with CPM. What I could do is sending this patch to the maintainers of the git repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No fetching during compilation
@robwoolley is needed for the Foxglove stuff. What's also not yet building :-(