Use portable bit-rate logging in ffmpeg_encoder_decoder - #13
Merged
Conversation
Author
|
FYI @wep21 and @traversaro, this upstream PR comes from the RoboStack patch upstreaming tracker: RoboStack/robostack.github.io#16. Origin patch: RoboStack |
Contributor
|
First, thank you for the PR! |
Tobias-Fischer
force-pushed
the
codex/robostack-rolling-ffmpeg-encoder-decoder-bit-rate-log
branch
from
July 19, 2026 21:28
fcfe108 to
2a8ad78
Compare
Author
|
Sure, done. Thanks for the quick review @berndpfrommer |
This upstreams RoboStack downstream patch `patch/ros-rolling-ffmpeg-encoder-decoder.unix.patch`. bitRate_ is int64_t, so logging it through a long-specific format can warn or fail on platforms where long and int64_t differ. Use the PRId64 format macro from <cinttypes> so the printf-style log format matches the fixed-width integer type portably. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Tobias-Fischer
force-pushed
the
codex/robostack-rolling-ffmpeg-encoder-decoder-bit-rate-log
branch
from
July 19, 2026 22:45
2a8ad78 to
5291ae7
Compare
Contributor
|
Thanks for the PR! |
Tobias-Fischer
deleted the
codex/robostack-rolling-ffmpeg-encoder-decoder-bit-rate-log
branch
July 20, 2026 03:55
Author
Thanks for the quick review + merge, amazing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an effort to contribute RoboStack downstream patches back upstream.
Origin: RoboStack
patch/ros-rolling-ffmpeg-encoder-decoder.unix.patch, authored by Daisuke Nishimatsu.Best-guess rationale: bitRate_ is int64_t, so logging it through a long-specific format can warn or fail on platforms where long and int64_t differ; casting to long long with a matching format keeps the log statement portable.