Skip to content

Fix preprocessor directives in cros.h - #15

Open
blanquez wants to merge 1 commit into
ros-industrial-attic:masterfrom
blanquez:fix_crosh
Open

Fix preprocessor directives in cros.h#15
blanquez wants to merge 1 commit into
ros-industrial-attic:masterfrom
blanquez:fix_crosh

Conversation

@blanquez

Copy link
Copy Markdown

Fixed preprocessor directive in cros.h to protect the header correctly

@blanquez

Copy link
Copy Markdown
Author

@rrcarrillo I have opened this PR to fix the issue in cros.h. I have no permission to add a reviewer since I am not a collaborator.

@rrcarrillo

Copy link
Copy Markdown
Contributor

Thank you for the fix. I think that this pull request should be approved, but I don't have write access to this project. Maybe @gavanderhoorn could approve the changes?

@gavanderhoorn

Copy link
Copy Markdown
Member

I'm slightly out of the loop here.

None of the original maintainers of cROS appear to be active any more.

What are your affiliations @blanquez and @rrcarrillo?

@rrcarrillo

Copy link
Copy Markdown
Contributor

Hi @gavanderhoorn, when I started contributing to cROS my affiliation was "Institut de la Vision, Sorbonne University, Paris". Now my affiliation is "Department of Computer Architecture and Technology, University of Granada, Granada"

@gavanderhoorn

Copy link
Copy Markdown
Member

Thanks.

So what is the status of it-robotics? The accounts from the two previous maintainers don't appear to have been active for at least a year if not longer.

Would you @rrcarrillo be the de facto maintainer of cROS now?

@rrcarrillo

Copy link
Copy Markdown
Contributor

I don't know what the status of it-robotics is, I have no relationship with them.
If no one else wants to be in charge, I can be the de facto maintainer of cROS. I don't have much time to spend on the project, but someone should approve the pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants