refactor: drop dead API surface and hoist record-type sets to module level - #70
Merged
Conversation
…level TtlockBleApiClient.credentials had no production caller; its only use was a test asserting the passthrough, so both go. _classify_record rebuilt four sets on every log entry; they are now module-level frozensets alongside PASSCODE_RECORD_TYPES. data/runtime.py was the one module importing its own package by absolute path; it now uses parent-relative imports, with TID252 ignored to match the repo's relative-import convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small internal cleanups, no behavior change:
TtlockBleApiClient.credentialshad no production caller — its only consumer was a test asserting the passthrough. Property and test removed._classify_recordrebuilt foursets ofLogOperatemembers on every log entry. They now live as module-levelfrozensetconstants next toPASSCODE_RECORD_TYPES, which already followed that pattern.data/runtime.pywas the only module importing its own package via the absolutecustom_components.ttlock_ble.path. It now uses parent-relative imports (..connection,..coordinator), withTID252added to the ruff ignore list to match the repo's documented relative-import convention.Verification
Full lint + mypy + test suite green (261 passed, coverage 100%).