fix: remove registry devices for locks that leave the entry's key set - #68
Merged
Conversation
Reauth and reconfigure replace the stored keys wholesale with whatever the cloud returns, so a lock removed from the TTLock account lingered as a dead device that the UI refused to delete. Setup now prunes registry devices whose MAC is no longer among the entry's keys, and async_remove_config_entry_device lets the UI delete any device whose lock is gone while protecting the configured ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A lock removed from the TTLock account became a permanent orphan: reauth and reconfigure replace
entry.data["keys"]wholesale with whatever the cloud returns, but the device registry kept the old device and the UI offered no way to delete it (the integration did not implementasync_remove_config_entry_device).Changes
async_setup_entrynow prunes registry devices whose MAC is no longer among the entry's stored keys, so a reauth/reconfigure that drops a lock cleans up its device on the reload that follows.async_remove_config_entry_deviceis implemented: the UI can delete a device whose lock is gone from the key set, while devices for configured locks stay protected.Tests
async_remove_config_entry_devicedenies removal for a configured lock and allows it for a stale one.Suite: 266 passed, coverage 100%.