Skip to content

test: some suggestions for making failing test file more readable #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maelle wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test: some suggestions for making failing test file more readable #10

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ca83eb
test: remove call to load() cf https://r-pkgs.org/data.html#sec-data-…
maelle Sep 30, 2024
171f5da
test: use expect_lt() and expect_gt() for a more informative error me…
maelle Sep 30, 2024
1bc3285
test: use more specific expectations for class
maelle Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 26 additions & 14 deletions tests/testthat/test-cetesb_retrieve_met_pol.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
test_that("cetesb_retrieve_met_pol works!", {

load("sysdata.rda")

pinheiros <- cetesb_retrieve_met_pol(u,p,aqs_code = 99,
start_date = "01/01/2020",
end_date = "07/01/2020")
Expand All @@ -12,20 +10,34 @@ test_that("cetesb_retrieve_met_pol works!", {

# Testing data.frame values
param_means<- colMeans(pinheiros[, 2:13], na.rm = TRUE)
expect_equal(param_means["tc"] > 23, param_means["tc"] < 24)
expect_equal(param_means["rh"] > 74, param_means["rh"] < 75)
expect_equal(param_means["ws"] > 1, param_means["ws"] < 2)
expect_equal(param_means["wd"] > 238, param_means["wd"] < 239)
expect_equal(param_means["o3"] > 27, param_means["o3"] < 28)
expect_equal(param_means["no"] > 8, param_means["no"] < 9)
expect_equal(param_means["no2"] > 26, param_means["no2"] < 27)
expect_equal(param_means["nox"] > 20, param_means["nox"] < 21)
expect_equal(param_means["co"] > 0.3, param_means["co"] < 0.4)
expect_equal(param_means["pm10"] > 19, param_means["pm10"] < 20)
expect_equal(param_means["pm25"] > 5, param_means["pm25"] < 7)
expect_lt(param_means["tc"], 23)
expect_gt(param_means["tc"], 24)
expect_lt(param_means["rh"], 74)
expect_gt(param_means["rh"], 75)
expect_lt(param_means["ws"], 1)
expect_gt(param_means["ws"], 2)
expect_lt(param_means["wd"], 238)
expect_gt(param_means["wd"], 239)
expect_lt(param_means["o3"], 27)
expect_gt(param_means["o3"], 28)
expect_lt(param_means["no"], 8)
expect_gt(param_means["no"], 9)
expect_lt(param_means["no2"], 26)
expect_gt(param_means["no2"], 27)
expect_lt(param_means["nox"], 20)
expect_gt(param_means["nox"], 21)
expect_lt(param_means["co"], 0.3)
expect_gt(param_means["co"], 0.4)
expect_lt(param_means["pm10"], 19)
expect_gt(param_means["pm10"], 20)
expect_lt(param_means["pm25"], 5)
expect_gt(param_means["pm25"], 7)

# Testing data.frame classes
expect_equal(TRUE, "data.frame" %in% class(pinheiros))
expect_s3_class(pinheiros, "data.frame")
expect_type(pinheiros$tc, "double")
# but probably better
# expect_setequal(unname(apply(pinheiros, 2, class)), c(<vector-of-classes>))
expect_equal(TRUE, "numeric" %in% class(pinheiros$tc))
expect_equal(TRUE, "numeric" %in% class(pinheiros$rh))
expect_equal(TRUE, "numeric" %in% class(pinheiros$ws))
Expand Down