Skip to content

[ntuple] fix anchor decompression in mini file - #23940

Merged
jblomer merged 1 commit into
root-project:masterfrom
jblomer:ntuple-fix-minifile
Nov 4, 2026
Merged

jblomer merged 1 commit into
root-project:masterfrom
jblomer:ntuple-fix-minifile

Conversation

@jblomer

@jblomer jblomer commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Make the anchor decompression more robust by

  • Checking for invalid anchor size vs. length
  • Using the on-disk size for the input buffer (instead of the length)

Issue reported by Johnny Kao

@jblomer jblomer self-assigned this Nov 2, 2026
@Johnny-Kao

Copy link
Copy Markdown

@jblomer Thank you for raising this PR on my behalf! Really appreciate it.

@jblomer
jblomer force-pushed the ntuple-fix-minifile branch 2 times, most recently from 06dec35 to cd4c55d Compare November 2, 2026 09:13
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 14h 24m 31s ⏱️
 3 883 tests  3 883 ✅ 0 💤 0 ❌
76 010 runs  76 010 ✅ 0 💤 0 ❌

Results for commit 497ce2f.

♻️ This comment has been updated with latest results.

Comment thread tree/ntuple/src/RMiniFile.cxx Resolved
Comment thread tree/ntuple/src/RMiniFile.cxx Resolved
Comment thread tree/ntuple/src/RMiniFile.cxx Resolved
Comment thread tree/ntuple/test/ntuple_minifile.cxx Resolved
@jblomer
jblomer force-pushed the ntuple-fix-minifile branch from cd4c55d to 497ce2f Compare November 3, 2026 12:35
@jblomer
jblomer requested a review from pcanal November 3, 2026 12:36
Make the anchor decompression more robust by
  - Checking for invalid anchor size vs. length
  - Using the on-disk size for the input buffer (instead of the length)

Issue reported by Johnny Kao

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread tree/ntuple/test/ntuple_minifile.cxx Resolved
@jblomer
jblomer merged commit 916c66b into root-project:master Nov 4, 2026
34 checks passed
@jblomer
jblomer deleted the ntuple-fix-minifile branch November 4, 2026 11:31
@jblomer

jblomer commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

/backport to 6.42

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #23940 to branch 6.42 requested by jblomer

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.42: #23980

@jblomer

jblomer commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

/backport to 6.40

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #23940 to branch 6.40 requested by jblomer

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.40: #23982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants