Repository navigation
[builtins] Install the builtin mathjax distribution together with JSROOT - #23908
Conversation
With builtin_mathjax=ON, the mathjax distribution is only unpacked into js/mathjax in the build tree, but nothing installs it: the install rule for JSROOT copies the js directory of the source tree. JSROOT loads mathjax/es5/tex-svg.js relative to its own location (see js/modules/base/latex.mjs), so an installed ROOT always falls back to the CDN, and the builtin_mathjax option has no effect for the installation. Install the distribution next to JSROOT, like in the build tree.
|
There is PR #23877 which converts jsroot into builtin option. Probably I should add there install instruction there for: Then this PR will be not necessary |
|
Yep I'm aware of that! But do you really plan to port #23877 at this point? Looks like a fat change for making after the 6.42.00 release candidate is already out. And I think your |
Not sure yet. |
Okay. In this case, are you fine with merging my PR here, so things work correctly for the release whatever is the fate of #23877? |
If you want to backport it to 6.42 - then let merge yours first and I will rebase my PR |
|
/backport to 6.42 |
|
Preparing to backport PR #23908 to branch 6.42 requested by guitargeek |
|
This PR has been backported to branch 6.42: #23913 |
With builtin_mathjax=ON, the mathjax distribution is only unpacked into js/mathjax in the build tree, but nothing installs it: the install rule for JSROOT copies the js directory of the source tree. JSROOT loads mathjax/es5/tex-svg.js relative to its own location (see js/modules/base/latex.mjs), so an installed ROOT always falls back to the CDN, and the builtin_mathjax option has no effect for the installation.
Install the distribution next to JSROOT, like in the build tree.
Fixes the problem that
js/mathjaxis missing from the install tree:This is another fix when I exercised the nix packaging of the 6.42.00 release candidate.