Repository navigation
[CMake] Do not patch clad when an external clad source directory is used - #23906
Merged
Merged
Conversation
An external clad source directory passed via CLAD_SOURCE_DIR is expected to be already patched if necessary. It might also be read-only or not a git repository, in which case the patch step with git checkout and git apply fails. So skip the patch step in this case.
dpiparo
approved these changes
Oct 30, 2026
Contributor
Author
|
/backport to 6.42 |
|
Preparing to backport PR #23906 to branch 6.42 requested by guitargeek |
|
This PR has been backported to branch 6.42: #23912 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An external clad source directory passed via CLAD_SOURCE_DIR is expected to be already patched if necessary. It might also be read-only or not a git repository, in which case the patch step with git checkout and git apply fails. So skip the patch step in this case.
This is a requirement for the ROOT nix package, where Clad is side-loaded via CLAD_SOURCE_DIR, because nix builds happen in a sandbox without internet connection.
To be backported to 6.42