Repository navigation
Improve file handling in string_view.py test - #23886
Merged
vepadulano merged 2 commits intoNov 2, 2026
Merged
vepadulano merged 2 commits into
vepadulano merged 2 commits into
Conversation
Test Results 21 files 21 suites 3d 9h 11m 6s ⏱️ Results for commit cd680ff. ♻️ This comment has been updated with latest results. |
guitargeek
approved these changes
Oct 31, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Just two small improvement suggestion.
Separate the logic of the test in a different function. In the function calling the test, i.e. `test_rdataframe`, the file removal can be scheduled in a `finally` block after the end of the function scope using RDataFrame. This should ensure that the RDataFrame object has been destroyed and the file can be safely removed on all platforms (including Windows).
vepadulano
force-pushed
the
python-reorganise-string-view-test
branch
from
November 2, 2026 08:59
8b54d03 to
cd680ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate the logic of the test in a different function. In the function
calling the test, i.e.
test_rdataframe, the file removal can bescheduled in a
finallyblock after the end of the function scope usingRDataFrame. This should ensure that the RDataFrame object has been
destroyed and the file can be safely removed on all platforms (including
Windows).