Repository navigation
[6.40] Fix off-by-one error for merging nested directories - #23882
Merged
enirolf merged 3 commits intoOct 29, 2026
Merged
Conversation
Instead of comparing the *file* of the source directory to the target directory, we should be comparing it to the *file* of the target directory. (cherry picked from commit cd13299)
Regression test for root-project#23666 Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com> (cherry picked from commit 272aa00)
...directly using `hadd`, and not only the TFileMerger (cherry picked from commit df488ea)
dpiparo
added
bug
in:I/O
experiment
root-project-bot
requested review from
bellenot,
dpiparo and
pcanal
as code owners
October 29, 2026 08:06
Test Results 23 files 23 suites 3d 19h 39m 43s ⏱️ Results for commit 3e915aa. |
enirolf
merged commit Oct 29, 2026
4fa6bf8
into
root-project:v6-40-00-patches
43 of 46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23878, requested by @enirolf.