Repository navigation
[ntuple] Avoid keeping too many files open in RNTupleChainProcessor - #23879
Merged
vepadulano merged 1 commit intoOct 31, 2026
Conversation
RNTupleProcessor::GetNEntries is called (at the moment) by RNTupleProcessorDS. This commit proposes to not keep the page sources after having opened them, but to only get the number of entries and then close them. This avoids the issue in datasource_ntuple_processor.cxx test "error: Too many files open", seen on the Windows CI and visible also on a UNIX system by calling 'ulimit -n' with a number lower than the number of files of the chain in the test (1000).
vepadulano
requested review from
hageboeck,
jblomer and
silverweed
as code owners
October 28, 2026 15:45
Test Results 24 files 24 suites 4d 0h 18m 29s ⏱️ Results for commit 8771300. ♻️ This comment has been updated with latest results. |
Member
Author
|
Stopped CI runs to avoid overloading runners before the rc, will re-run afterwards. |
Member
Author
|
Just to show that on my Fedora node I see:
|
jblomer
approved these changes
Oct 28, 2026
Member
Author
|
/backport to 6.42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RNTupleProcessor::GetNEntries is called (at the moment) by RNTupleProcessorDS. This commit proposes to not keep the page sources after having opened them, but to only get the number of entries and then close them. This avoids the issue in
datasource_ntuple_processor.cxx test "error: Too many files open", seen on the Windows CI and visible also on a UNIX system by calling 'ulimit -n' with a number lower than the number of files of the chain in the test (1000).