Repository navigation
[ML] Move the RDataLoader tests to pytest - #23819
Open
siliataider wants to merge 8 commits into
Open
siliataider wants to merge 8 commits into
siliataider wants to merge 8 commits into
Conversation
siliataider
marked this pull request as draft
October 23, 2026 15:54
siliataider
force-pushed
the
rdataloader-tests-pytest
branch
from
October 23, 2026 16:09
e650945 to
38118fb
Compare
Test Results 24 files 24 suites 3d 22h 50m 58s ⏱️ For more details on these failures, see this check. Results for commit 74e1241. ♻️ This comment has been updated with latest results. |
siliataider
force-pushed
the
rdataloader-tests-pytest
branch
4 times, most recently
from
October 29, 2026 17:02
deb114f to
4cf4f42
Compare
siliataider
marked this pull request as ready for review
October 29, 2026 17:09
The test classes no longer derive from unittest.TestCase, their names get the "Test" prefix fot pytest to collect. Assisted-by: Claude Opus 5.5
Each test now runs in its own temporary directory which pytest creates and cleans up. The next commits will use these. the fixtures are dupliucated in this commit because the tests are duplicated for lazy and eager loading modes, the test classes will be merged in a future commit and so will the fixtures. Assisted-by: Claude Opus 5.5
This remooves the try/except/finally blocks in favour of using the fixtures defined previously. Assisted-by: Claude Opus 5.5
Assisted-by: Claude Opus 5.5
…etrized test each The eager and lazy versions of the tests were near copies of each other They are now merged into the sam etest class and use a parametrized fixture to switch between modes. The tests that only existed for one of the modes still only run for it only. Assisted-by: Claude Opus 5.5
Assisted-by: Claude Opus 5.5
siliataider
force-pushed
the
rdataloader-tests-pytest
branch
from
October 30, 2026 09:35
4cf4f42 to
74e1241
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes:
Moves the RDataLoader tests from
unittesttopytestto make them shorter and easier to read and to extend.The test logic is unchanged.
ml_dataloader.pyis split intoml_dataloader_single_dataframe.py,ml_dataloader_multiple_dataframes.py,ml_dataloader_undersampling.py,ml_dataloader_oversampling.py,ml_dataloader_save.py,ml_dataloader_implicit_mt.pyandml_dataloader_from_files.pyconftest.pytmp_path, created and deleted by pytesttry/except/finallyblocks and theos.removes that existed only to delete temporary filesTestDataLoaderSingleDataframeandTestDataLoaderMultipleDataframes, which run all of their tests twice (for both loading modes) using a parametrized fixtureChecklist: