Repository navigation
[image] fix TASImage::Append, unify clone of image data - #23787
Merged
Merged
Conversation
silverweed
reviewed
Oct 21, 2026
Test Results 24 files 24 suites 4d 2h 16m 54s ⏱️ For more details on these failures, see this check. Results for commit 7720358. ♻️ This comment has been updated with latest results. |
linev
changed the title
silverweed
approved these changes
Oct 22, 2026
Provide CloneImageData method which clone all memebers of the TASImage Include argb32 which can be already created because of painting.
Now CloneImageData() does the job - one only need to create new instance and set new name
When image does not have data - just clone data from source image. Fixing ownership problem when image pointer was copied and causing segfault when TASImage was deleted. It was a reason for memory leak in TRootSniffer when processing root.png request
TImage::Append() was used with "intentional" memory leak while second image took over ownership. Use of Append not necessary at all - one can use original image.
Verify that code does not crash and returns meaningful image size
Member
|
the failure is spurious. Good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was breaking ownership
Fix related place in TRootSnifferFull used to generate images
Add testing to http and sniffer