Repository navigation
Conversation
Before, the field name `std::vector<float> jets` would be set to `_0`. Now, we traverse up the fieldInfos to find the actual field name and set it accordingly.
Artificial fields adopt their on-disk ID from other fields. This commit adds a way to bookkeep how the on-disk ID of artificial fields should be set when they get updated.
enirolf
requested review from
hageboeck,
jblomer,
silverweed and
vepadulano
as code owners
October 16, 2026 16:58
enirolf
force-pushed
the
ntuple-ds-processor-rdffields
branch
from
October 16, 2026 19:40
49072fa to
62ad8f9
Compare
Test Results 24 files 24 suites 3d 23h 37m 5s ⏱️ For more details on these failures, see this check. Results for commit 62ad8f9. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the RNTupleProcessorDS crashes with chains of RNTuples that have collections, because the artificial cardinality fields cannot be reconnected properly when the next RNTuple is opened.
This fix adds an additional bookkeeping mechanism for artificial fields. It keeps track of the RNTupleProcessorEntry index of the field it should get the on-disk ID from and sets it accordingly upon connection.
Additionally, tests with more involved RNTupleProcessor combinations are added.
There is one outstanding FIXME also uncovered by these tests, which is the
#colnamealias for collection sizes. This doesn't work yet for fields belonging to auxiliary RNTuples. It will be addressed in a future PR.