Repository navigation
[tmva][sofie] Read the alpha and gamma attributes of Selu - #23743
Open
Maher-star-eng wants to merge 1 commit into
Open
Maher-star-eng wants to merge 1 commit into
Maher-star-eng wants to merge 1 commit into
Conversation
ParseSelu ignored the alpha and gamma attributes and ROperator_Selu hard-coded their default values, so a Selu node with other values gave wrong results. Read both attributes, with the ONNX defaults, and write them into the generated code with full float precision, as Elu does for its alpha. Add a test model with non-default values. Fixes root-project#23734 Assisted-by: claude-code:claude-opus-5-5
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Makes SOFIE read the
alphaandgammaattributes of the ONNX Selu operator instead of always using their default values.Changes or fixes:
ParseSelunow readsalphaandgamma, defaulting to the values of the ONNX specification, in the same wayParseElureadsalpha.ROperator_Selustores both values and writes them into the generated code with full float precision (max_digits10), asROperator_Eludoes. Sincealphais now afloat,std::min(0.0, ...)becamestd::min(float(0.0), ...).ONNX.SeluAttributes: a Selu node withalpha=2.0, gamma=3.0and inputs on both sides of zero; the reference comes from the ONNX reference implementation. It fails without the fix on all four values and passes with it. All 11 SOFIE tests pass locally, includingLinearWithSeluwith the default values.AI disclosure: I found this bug with a script that runs the ONNX operator tests from the
onnxPython package through SOFIE (test_seluandtest_selu_examplegave wrong values); the script was written by Claude (a claude-sonnet-5-5 agent) .Also it gave me directions for the fix . I wrote the fix and the test by myself , and reviewed the changes and test result .
Checklist:
This PR fixes #23734