Skip to content

[640] [cling] treat empty SDKROOT as unset - #23727

Merged
dpiparo merged 2 commits into
root-project:v6-40-00-patchesfrom
dpiparo:fix_23712_640
Oct 16, 2026
Merged

dpiparo merged 2 commits into
root-project:v6-40-00-patchesfrom
dpiparo:fix_23712_640

Conversation

@dpiparo

@dpiparo dpiparo commented Oct 15, 2026

Copy link
Copy Markdown
Member

This is a BP of #23714, plus an additional commit necessary for it. Fixes #23712 for 6.40

dpiparo and others added 2 commits October 15, 2026 16:40
In order of priority:
 - Check if the -isysroot argument is being passed
 - If not, honour the env variable SDKROOT
 - Otherwise, use xcrun to locate the SDK

(cherry picked from commit 96d4abf)
Fixes root-project#23712

Full credit goes to cxwx

(cherry picked from commit 97db95a)
@dpiparo dpiparo self-assigned this Oct 15, 2026
@dpiparo
dpiparo requested a review from bellenot as a code owner October 15, 2026 14:43
@github-actions

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 13h 24m 50s ⏱️
 3 878 tests  3 878 ✅ 0 💤 0 ❌
77 633 runs  77 633 ✅ 0 💤 0 ❌

Results for commit 3aa38cb.

@dpiparo
dpiparo merged commit 71ce031 into root-project:v6-40-00-patches Oct 16, 2026
36 of 38 checks passed
@dpiparo
dpiparo deleted the fix_23712_640 branch October 16, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants