Repository navigation
[hadd] Fix roottest-root-io-hadd-test_hadd_args_minusminus2 - #23711
Merged
Merged
Conversation
The test was succeeding for the wrong reason because the hadd_args_verify.C macro didn't check whether the file was valid.
jblomer
approved these changes
Oct 14, 2026
Test Results 23 files 23 suites 3d 19h 27m 45s ⏱️ For more details on these failures, see this check. Results for commit 296e066. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was succeeding for the wrong reason because the hadd_args_verify.C macro didn't check whether the file was valid.
Checklist: