Repository navigation
[ntuple] Change RNTupleProcessor::CreateJoin factory to free function - #23701
Merged
Merged
Conversation
Temporarily, so we can keep the RNTupleJoinProcessor in Experimental for a bit longer, and take the rest out already. Once the RNTupleJoinProcessor moves out of Experimental, this change should be reverted.
enirolf
force-pushed
the
ntuple-proc-free-funcs
branch
from
October 13, 2026 15:13
90a2b4c to
8108090
Compare
enirolf
changed the title
RNTupleProcessor::CreateJoin factory to free function
Test Results 23 files 23 suites 4d 0h 49m 4s ⏱️ For more details on these failures, see this check. Results for commit 8108090. |
vepadulano
approved these changes
Oct 14, 2026
jblomer
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, we can keep the
RNTupleJoinProcessorin Experimental for a bit longer, and take theRNTupleProcessor(base class),RNTupleSingleProcessorandRNTupleChainProcessorout already.Once the
RNTupleJoinProcessormoves out of Experimental as well, this change should be reverted.Checklist: